notifyicon.go: a11y improvements to notification icons#135
Merged
Conversation
nickkhyl
approved these changes
Jun 27, 2025
We handle NIN_KEYSELECT and NIN_SELECT identically to WM_LBUTTONUP. We initialize the hidden event sink window with WS_DISABLED and annotate it with a window role instead of a client role, in the hope that this will discourage screen readers from focusing on it. Finally, we do a bit of cleanup since we're already in here. Updates tailscale/corp#29972 Signed-off-by: Aaron Klotz <aaron@tailscale.com>
dblohm7
force-pushed
the
aaron/disable_ni_event_sink
branch
from
48547f3 to
717711a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We handle NIN_KEYSELECT and NIN_SELECT identically to WM_LBUTTONUP.
We initialize the hidden event sink window with WS_DISABLED and annotate it with a window role instead of a client role, in the hope that this will discourage screen readers from focusing on it.
Finally, we do a bit of cleanup since we're already in here.
Updates https://github.com/tailscale/corp/issues/29972